Allow invoker of make check to test a subset of packages.
#13987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlm
approved these changes
Apr 27, 2022
Makefile
Outdated
| @@ -279,7 +283,7 @@ test: run-tests | |||
| run-tests: | |||
| ## run-tests: Run the unit tests | |||
| $(eval TMP := $(shell mktemp -d $${TMPDIR:-/tmp}/jj-XXX)) | |||
| $(eval TEST_PACKAGES := $(shell go list $(PROJECT)/... | grep -v $(PROJECT)$$ | grep -v $(PROJECT)/vendor/ | grep -v $(PROJECT)/acceptancetests/ | grep -v $(PROJECT)/generate/ | grep -v mocks)) | |||
| $(eval TEST_PACKAGES := $(shell go list $(PROJECT)/... | sort | ([ -f $(TEST_PACKAGE_LIST) ] && comm -12 $(TEST_PACKAGE_LIST) - || cat) | grep -v $(PROJECT)$$ | grep -v $(PROJECT)/vendor/ | grep -v $(PROJECT)/acceptancetests/ | grep -v $(PROJECT)/generate/ | grep -v mocks)) | |||
There was a problem hiding this comment.
I think you can combine all the greps into a list with [] might read a bit better then?
There was a problem hiding this comment.
I tried this and it was more messy but less verbose, so sticking with the current one.
hpidcock
force-pushed
the
filter-test-packages
branch
from
b6c2686
to
0441680
Compare
|
|
jujubot
added a commit
that referenced
this pull request
May 16, 2022
#14017 Merge from 2.9 to bring forward: - #14007 from wallyworld/update-golang-deps - #14013 from hmlanigan/show-controller-panic - #14012 from hmlanigan/remove-unit-subordinate - #13998 from turrisxyz/setup-permissions - #14011 from ycliuhw/update-ck-overlay - #14010 from tlm/juju-jenkins-tests - #14004 from tlm/juju-jenkins-tests - #14003 from manadart/2.9-close-unit-loggers - #14001 from jack-w-shaw/JUJU-1050_show_unit_life - #13890 from juju/dependabot/github_actions/actions/upload-artifact-3 - #14000 from wallyworld/use-go1.18 - #13999 from tlm/juju-jenkins-tests - #13991 from ycliuhw/fix/lp1968643 - #13997 from tlm/cross-compile - #13931 from arnodel/juju-885-remove-modelaccess-connection-iface-method - #13992 from jack-w-shaw/JUJU-1034_reduce_over_verbose_logging_network - #13993 from hmlanigan/fix-intermittent-fail-testenqueuedoperation - #13990 from wallyworld/handle-azure-quota-errors - #13989 from benhoyt/start-worker-if-dead - #13987 from hpidcock/filter-test-packages Conflicts: - cmd/juju/controller/showcontroller.go - go.mod - go.sum - provider/azure/environ_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By passing
TEST_PACKAGE_LISTenv var set to the path of a file with sorted newline delimited package import paths,make checkwill only test that subset.QA steps
make checkshould still test all the packages it normally tests.This should test only the
github.com/juju/juju/api/client/applicationpackage.echo github.com/juju/juju/api/client/application > test.list && TEST_PACKAGE_LIST=test.list make check && rm test.listDocumentation changes
N/A
Bug reference
N/A