Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JUJU-998] Fix/lp1968643 #13991

Merged
merged 8 commits into from May 3, 2022
Merged

[JUJU-998] Fix/lp1968643 #13991

merged 8 commits into from May 3, 2022

Conversation

ycliuhw
Copy link
Member

@ycliuhw ycliuhw commented Apr 28, 2022

This PR allows juju_start_unit, juju_stop_unit and juju_unit_status returning proper not supported errors on CAAS controller, operator and sidecar charm container.

Checklist

  • Requires a pylibjuju change
  • Added integration tests for the PR
  • Added or updated doc.go related to packages changed
  • Comments answer the question of why design decisions were made

QA steps

$ juju bootstrap microk8s k1

$ juju add-model t1

$ juju deploy hello-kubecon

$ juju deploy minio

$ mkubectl exec -ncontroller-k1 pod/controller-0 -c api-server  -it -- bash --login
root@controller-0:/var/lib/juju# juju_start_unit hello-kubecon/0
error: start units for {[hello-kubecon/0]} not supported
root@controller-0:/var/lib/juju# juju_stop_unit hello-kubecon/0
error: stop units for {[hello-kubecon/0]} not supported
root@controller-0:/var/lib/juju# juju_unit_status hello-kubecon/0
error: units status not supported

$ mkubectl exec -nt1 pod/hello-kubecon-0   -it -- bash --login
Defaulted container "charm" out of: charm, gosherve, charm-init (init)
root@hello-kubecon-0:/var/lib/juju# juju_start_unit hello-kubecon/0
error: start units for {[hello-kubecon/0]} not supported
root@hello-kubecon-0:/var/lib/juju# juju_stop_unit hello-kubecon/0
error: stop units for {[hello-kubecon/0]} not supported
root@hello-kubecon-0:/var/lib/juju# juju_unit_status hello-kubecon/0
error: units status not supported

$ mkubectl exec -nt1 pod/minio-operator-0   -it -- bash --login
root@minio-operator-0:/var/lib/juju# juju_start_unit minio/0
error: start units for {[minio/0]} not supported
root@minio-operator-0:/var/lib/juju# juju_stop_unit minio/0
error: stop units for {[minio/0]} not supported
root@minio-operator-0:/var/lib/juju# juju_unit_status minio/0
error: units status not supported

Documentation changes

No

Bug reference

https://bugs.launchpad.net/juju/+bug/1968643

@ycliuhw ycliuhw changed the title Fix/lp1968643 [JUJU-998] Fix/lp1968643 Apr 28, 2022
@ycliuhw ycliuhw marked this pull request as ready for review April 29, 2022 06:32
@ycliuhw ycliuhw force-pushed the fix/lp1968643 branch 2 times, most recently from ca9470c to fbbbb32 Compare April 29, 2022 07:31
@ycliuhw ycliuhw requested a review from wallyworld May 2, 2022 05:55
Copy link
Member

@wallyworld wallyworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

cmd/containeragent/unit/agent.go Outdated Show resolved Hide resolved
@ycliuhw
Copy link
Member Author

ycliuhw commented May 3, 2022

$$merge$$

@jujubot jujubot merged commit bda4b32 into juju:2.9 May 3, 2022
jujubot added a commit that referenced this pull request May 16, 2022
#14017

Merge from 2.9 to bring forward:
- #14007 from wallyworld/update-golang-deps
- #14013 from hmlanigan/show-controller-panic
- #14012 from hmlanigan/remove-unit-subordinate
- #13998 from turrisxyz/setup-permissions
- #14011 from ycliuhw/update-ck-overlay
- #14010 from tlm/juju-jenkins-tests
- #14004 from tlm/juju-jenkins-tests
- #14003 from manadart/2.9-close-unit-loggers
- #14001 from jack-w-shaw/JUJU-1050_show_unit_life
- #13890 from juju/dependabot/github_actions/actions/upload-artifact-3
- #14000 from wallyworld/use-go1.18
- #13999 from tlm/juju-jenkins-tests
- #13991 from ycliuhw/fix/lp1968643
- #13997 from tlm/cross-compile
- #13931 from arnodel/juju-885-remove-modelaccess-connection-iface-method
- #13992 from jack-w-shaw/JUJU-1034_reduce_over_verbose_logging_network
- #13993 from hmlanigan/fix-intermittent-fail-testenqueuedoperation
- #13990 from wallyworld/handle-azure-quota-errors
- #13989 from benhoyt/start-worker-if-dead
- #13987 from hpidcock/filter-test-packages

Conflicts:
- cmd/juju/controller/showcontroller.go
- go.mod
- go.sum
- provider/azure/environ_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants