[JUJU-1058] Close buffered logger upon termination of converged unit agent #14003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by the deployer worker. Calling Close() terminates the logger's loop. This prevents leakage of the Goroutines spawned to run the logger's loop method.
wallyworld
approved these changes
May 5, 2022
|
|
jameinel
reviewed
May 11, 2022
jujubot
added a commit
that referenced
this pull request
May 16, 2022
#14017 Merge from 2.9 to bring forward: - #14007 from wallyworld/update-golang-deps - #14013 from hmlanigan/show-controller-panic - #14012 from hmlanigan/remove-unit-subordinate - #13998 from turrisxyz/setup-permissions - #14011 from ycliuhw/update-ck-overlay - #14010 from tlm/juju-jenkins-tests - #14004 from tlm/juju-jenkins-tests - #14003 from manadart/2.9-close-unit-loggers - #14001 from jack-w-shaw/JUJU-1050_show_unit_life - #13890 from juju/dependabot/github_actions/actions/upload-artifact-3 - #14000 from wallyworld/use-go1.18 - #13999 from tlm/juju-jenkins-tests - #13991 from ycliuhw/fix/lp1968643 - #13997 from tlm/cross-compile - #13931 from arnodel/juju-885-remove-modelaccess-connection-iface-method - #13992 from jack-w-shaw/JUJU-1034_reduce_over_verbose_logging_network - #13993 from hmlanigan/fix-intermittent-fail-testenqueuedoperation - #13990 from wallyworld/handle-azure-quota-errors - #13989 from benhoyt/start-worker-if-dead - #13987 from hpidcock/filter-test-packages Conflicts: - cmd/juju/controller/showcontroller.go - go.mod - go.sum - provider/azure/environ_test.go
|
While it would be fairly easy to use a tomb/context in the case addressed here I.e. the unit agent runner, it is messier for the other agent cases where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installation of a buffered logger, used to ship logs to controllers, spawns a Goroutine that is not managed.
This was not a problem when it was created in the
mainmethod for jujud, because there was only ever one per agent, and an agent restart would cause termination of the Goroutine.When unit agents were converged as runners into the machine agent, this changed. Now, a terminated unit agent leaves these Goroutines behind.
Here we call the logger's
Closemethod when the unit worker's dependency engine completes. This closure causes the loop running in the Goroutine to terminate.QA steps
A test for this would involve repeatedly causing machine agents to soft bounce (restarting their worker graphs). Introspection of the agent's Goroutines would indicate that we are not accumulating them over time.
Documentation changes
None.
Bug reference
N/A