[JUJU-1050] Output life in juju show-unit and juju show-application
#14001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-w-shaw
force-pushed
the
JUJU-1050_show_unit_life
branch
from
2e7a916
to
06509b6
Compare
jack-w-shaw
changed the title
juju show-unitjuju show-unit and juju show-application
jack-w-shaw
force-pushed
the
JUJU-1050_show_unit_life
branch
3 times, most recently
from
88c7b8f
to
bf2574c
Compare
|
@jack-w-shaw - QA is good for same client/controller. New client with older controller yields for show-unit, but not for show-application. A usability nit. |
hmlanigan
reviewed
May 4, 2022
jack-w-shaw
force-pushed
the
JUJU-1050_show_unit_life
branch
from
bf2574c
to
7809a18
Compare
jack-w-shaw
force-pushed
the
JUJU-1050_show_unit_life
branch
from
7809a18
to
e01c6f8
Compare
|
|
jujubot
added a commit
that referenced
this pull request
May 16, 2022
#14017 Merge from 2.9 to bring forward: - #14007 from wallyworld/update-golang-deps - #14013 from hmlanigan/show-controller-panic - #14012 from hmlanigan/remove-unit-subordinate - #13998 from turrisxyz/setup-permissions - #14011 from ycliuhw/update-ck-overlay - #14010 from tlm/juju-jenkins-tests - #14004 from tlm/juju-jenkins-tests - #14003 from manadart/2.9-close-unit-loggers - #14001 from jack-w-shaw/JUJU-1050_show_unit_life - #13890 from juju/dependabot/github_actions/actions/upload-artifact-3 - #14000 from wallyworld/use-go1.18 - #13999 from tlm/juju-jenkins-tests - #13991 from ycliuhw/fix/lp1968643 - #13997 from tlm/cross-compile - #13931 from arnodel/juju-885-remove-modelaccess-connection-iface-method - #13992 from jack-w-shaw/JUJU-1034_reduce_over_verbose_logging_network - #13993 from hmlanigan/fix-intermittent-fail-testenqueuedoperation - #13990 from wallyworld/handle-azure-quota-errors - #13989 from benhoyt/start-worker-if-dead - #13987 from hpidcock/filter-test-packages Conflicts: - cmd/juju/controller/showcontroller.go - go.mod - go.sum - provider/azure/environ_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Juju only inconsistently outputs the
lifestatus of entities when runningjuju show-. This PR is the first step in making this consistentChecklist
[ ] Requires a pylibjuju change[ ] Added or updated doc.go related to packages changedQA steps
Deploy something big and complex
And wait for it to be fully deployed
Test show-unit with alive unit
Test show-application with alive application
This is not sufficient QA, however, since
alivecorresponds to the integer 0, so this value could just be uninitialised under the hoodDestroy the model, and quickly whilst units are dying, check
show-xUnit
and application
Bug reference
https://bugs.launchpad.net/juju/+bug/1968092