Implement ForwardConstraintFunction for QuadToSOCBridge #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #232 +/- ##
==========================================
+ Coverage 86.19% 87.37% +1.18%
==========================================
Files 11 11
Lines 920 1006 +86
==========================================
+ Hits 793 879 +86
Misses 127 127
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
matbesancon
reviewed
Mar 1, 2023
matbesancon
reviewed
Mar 1, 2023
matbesancon
reviewed
Mar 1, 2023
|
the test file is also not included yet in test/runtests.jl |
matbesancon
reviewed
Mar 1, 2023
src/bridges.jl
Outdated
| """ | ||
| dU_from_dQ!(dQ, U) | ||
|
|
||
| Overwrite `dQ` into `dU` the solution of |
There was a problem hiding this comment.
Overwrite
dQintodU
sounds like we have a dangling argument dU that is not present.
matbesancon
reviewed
Mar 1, 2023
|
yes all good for me! |
matbesancon
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.