Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename user-facing functions for style compliance #1442

Merged
merged 1 commit into from
Aug 27, 2018
Merged

rename user-facing functions for style compliance #1442

merged 1 commit into from
Aug 27, 2018

Conversation

mlubin
Copy link
Member

@mlubin mlubin commented Aug 26, 2018

Mostly focused on user-facing functions to break the important parts first. Includes optimize -> optimize! for consistency with MOI.

Closes #1382

@codecov
Copy link

codecov bot commented Aug 27, 2018

Codecov Report

Merging #1442 into master will decrease coverage by 0.01%.
The diff coverage is 98.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1442      +/-   ##
==========================================
- Coverage   88.87%   88.86%   -0.02%     
==========================================
  Files          25       25              
  Lines        3695     3691       -4     
==========================================
- Hits         3284     3280       -4     
  Misses        411      411
Impacted Files Coverage Δ
src/optimizerinterface.jl 73.91% <ø> (ø) ⬆️
src/nlp.jl 82.01% <0%> (ø) ⬆️
src/operators.jl 88.3% <100%> (ø) ⬆️
src/macros.jl 89.64% <100%> (ø) ⬆️
src/quadexpr.jl 90.69% <100%> (ø) ⬆️
src/print.jl 80.54% <100%> (-0.42%) ⬇️
src/parseexpr.jl 94.09% <100%> (ø) ⬆️
src/affexpr.jl 95.27% <100%> (ø) ⬆️
src/variables.jl 88.37% <100%> (ø) ⬆️
src/JuMP.jl 77.03% <87.5%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d281d0...f7e1948. Read the comment docs.

@blegat
Copy link
Member

blegat commented Aug 27, 2018

I agree with optimize -> optimize!. The fact that it does not remove the solution but modifies its internals to contain the solution also apply here

@mlubin mlubin merged commit 525b2b5 into master Aug 27, 2018
@mlubin mlubin deleted the ml/rename branch August 27, 2018 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants