[FileFormats.MPS] write OBJSENSE on new line, and loosen parsing rules #2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x-ref: #2016 (comment)
All solvers are maddeningly different in how they want
OBJSENSE:Gurobi want it on the same line https://www.gurobi.com/documentation/9.5/refman/mps_format.html
Mosek want it in field 2 (col 5) on a new line https://docs.mosek.com/10.0/pythonfusion/mps-format.html
CPLEX wants it in column 3 (not a field!) on a new line https://www.ibm.com/docs/en/icos/22.1.0?topic=extensions-objective-sense-name-offset-in-mps-files
Mosek is the only sane one here, and from testing, it seems like the rest can at least read it, so I've changed to that.x