Add ToScalarNonlinearBridge #2834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah. I think this may have been a mistake. We could somehow restrict to only supporting |
|
I pushed a couple of tweaks. I'll see if there are any test issues. I don't think we have sufficient tests to catch the constraint case. But I'll worry about that separately. |
odow
approved these changes
Sep 7, 2025
This was referenced Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #2833.
Do you think this is a reasonable approach?
One problematic thing (in my opinion) is that I had to remove the nonlinear bridge from a few tests, because it is not bound to a type.
However, this probably is an issue for constraints already, right?