-
Notifications
You must be signed in to change notification settings - Fork 8
Add KirlikSayin algorithm #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The format-check failed: https://github.com/odow/MultiObjectiveAlgorithms.jl/actions/runs/4118661658/jobs/7112702117 The easiest way to fix it is via: cd("~/.julia/dev/MultiObjectiveAlgorithms") # Or what ever the path is
] add JuliaFormatter
using JuliaFormatter
format(".") |
So I don't think the x86 failure is your fault. This is a known bug in HiGHS. But I wonder if we could remove or simplify the |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #22 +/- ##
=========================================
Coverage ? 86.48%
=========================================
Files ? 6
Lines ? 466
Branches ? 0
=========================================
Hits ? 403
Misses ? 63
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good!
I think we just need to tidy up the docstring and add the algorithm to the README.md: https://github.com/jump-dev/MultiObjectiveAlgorithms.jl/blob/master/README.md#algorithm
I'm in the process of registering this package, so it will soon be available via JuMP: jump-dev/JuMP.jl#3176. Here's a preview of what's to come: https://jump.dev/JuMP.jl/previews/PR3176/tutorials/linear/multi_objective_knapsack. I hope this will be useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'll merge once CI finishes.
Nice! |
I added a few line for the MOI.MAX_SENSE. Added tests for assignment and 4-objective knapsack.