Skip to content

Conversation

kofgokhan
Copy link
Contributor

I added a few line for the MOI.MAX_SENSE. Added tests for assignment and 4-objective knapsack.

@kofgokhan kofgokhan changed the title Ks modo Add KirlikSayin algorithm Feb 7, 2023
@odow
Copy link
Member

odow commented Feb 7, 2023

The format-check failed: https://github.com/odow/MultiObjectiveAlgorithms.jl/actions/runs/4118661658/jobs/7112702117

The easiest way to fix it is via:

cd("~/.julia/dev/MultiObjectiveAlgorithms")  # Or what ever the path is
] add JuliaFormatter
using JuliaFormatter
format(".")

@odow
Copy link
Member

odow commented Feb 11, 2023

So I don't think the x86 failure is your fault. This is a known bug in HiGHS.

But I wonder if we could remove or simplify the test_assignment_max_p3 test for now.

@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@8654901). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #22   +/-   ##
=========================================
  Coverage          ?   86.48%           
=========================================
  Files             ?        6           
  Lines             ?      466           
  Branches          ?        0           
=========================================
  Hits              ?      403           
  Misses            ?       63           
  Partials          ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good!

I think we just need to tidy up the docstring and add the algorithm to the README.md: https://github.com/jump-dev/MultiObjectiveAlgorithms.jl/blob/master/README.md#algorithm

I'm in the process of registering this package, so it will soon be available via JuMP: jump-dev/JuMP.jl#3176. Here's a preview of what's to come: https://jump.dev/JuMP.jl/previews/PR3176/tutorials/linear/multi_objective_knapsack. I hope this will be useful.

Copy link
Member

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll merge once CI finishes.

@odow odow merged commit 24ed32c into jump-dev:master Feb 12, 2023
@odow
Copy link
Member

odow commented Feb 12, 2023

Nice!

@kofgokhan kofgokhan deleted the ks-modo branch February 14, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants