Skip to content

Conversation

kofgokhan
Copy link
Contributor

@kofgokhan kofgokhan commented Feb 19, 2023

Link for the algorithm: https://doi.org/10.1016/0377-2217(86)90093-7

I looked at NISE.jl implementation. Maybe a few more functions can be added to make optimize_multiobjective! more readable although I was not sure how to set it up.

Also, I did not add any attributes to this one either.

Closes #15

@codecov
Copy link

codecov bot commented Feb 19, 2023

Codecov Report

Base: 95.53% // Head: 95.86% // Increases project coverage by +0.32% 🎉

Coverage data is based on head (bd6b2f4) compared to base (b03c3ff).
Patch coverage: 95.94% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   95.53%   95.86%   +0.32%     
==========================================
  Files           7        8       +1     
  Lines         650      725      +75     
==========================================
+ Hits          621      695      +74     
- Misses         29       30       +1     
Impacted Files Coverage Δ
src/algorithms/Chalmet.jl 95.94% <95.94%> (ø)
src/algorithms/NISE.jl
src/algorithms/Dichotomy.jl 98.07% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@odow
Copy link
Member

odow commented Feb 19, 2023

Maybe a few more functions can be added to make optimize_multiobjective! more readable although I was not sure how to set it up.

Looks okay for now. We can always improve later.

Also, I did not add any attributes to this one either.

Can improve later.

@odow
Copy link
Member

odow commented Feb 19, 2023

The README also needs updating

@odow odow mentioned this pull request Feb 19, 2023
2 tasks
@odow
Copy link
Member

odow commented Feb 19, 2023

Looks good! Once this is merged I think this package is in a good place. I'm interested to see what feedback we get once people start using it

@odow odow merged commit 4225428 into jump-dev:master Feb 19, 2023
@xgandibleux
Copy link

Indeed!!! It is crazy to see the speed how this package has been developped these last weeks. I will contact the authors of algorithms recently published that I know personally (N. Boland, D. Vanderpooten, A. Lohne, etc.) to invite them to add their implementation. Same for us (we have several codes that we could add, after a refactoring/reimplementation from C to Julia). I have also some ideas to facilitate the querying of results. And I am exited to present this new package in my lectures

@kofgokhan kofgokhan deleted the chalmet branch February 21, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Algorithms to add
3 participants