-
Notifications
You must be signed in to change notification settings - Fork 8
Add Chalmet algorithm #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 95.53% // Head: 95.86% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #41 +/- ##
==========================================
+ Coverage 95.53% 95.86% +0.32%
==========================================
Files 7 8 +1
Lines 650 725 +75
==========================================
+ Hits 621 695 +74
- Misses 29 30 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Looks okay for now. We can always improve later.
Can improve later. |
The README also needs updating |
Looks good! Once this is merged I think this package is in a good place. I'm interested to see what feedback we get once people start using it |
Indeed!!! It is crazy to see the speed how this package has been developped these last weeks. I will contact the authors of algorithms recently published that I know personally (N. Boland, D. Vanderpooten, A. Lohne, etc.) to invite them to add their implementation. Same for us (we have several codes that we could add, after a refactoring/reimplementation from C to Julia). I have also some ideas to facilitate the querying of results. And I am exited to present this new package in my lectures |
Link for the algorithm: https://doi.org/10.1016/0377-2217(86)90093-7
I looked at NISE.jl implementation. Maybe a few more functions can be added to make
optimize_multiobjective!
more readable although I was not sure how to set it up.Also, I did not add any attributes to this one either.
Closes #15