Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused S parameter #48

Merged
merged 1 commit into from
Feb 25, 2023
Merged

Remove unused S parameter #48

merged 1 commit into from
Feb 25, 2023

Conversation

blegat
Copy link
Member

@blegat blegat commented Feb 25, 2023

This gives warning when using the package

WARNING: method definition for set at /home/blegat/.julia/packages/MultiObjectiveAlgorithms/80Aze/src/MultiObjectiveAlgorithms.jl:348 declares type variable S but does not use it.
WARNING: method definition for set at /home/blegat/.julia/packages/MultiObjectiveAlgorithms/80Aze/src/MultiObjectiveAlgorithms.jl:372 declares type variable S but does not use it.

so it's worth doing a patch release with this fix

@codecov
Copy link

codecov bot commented Feb 25, 2023

Codecov Report

Base: 95.89% // Head: 95.81% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (d1b5902) compared to base (2d96a72).
Patch coverage: 93.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   95.89%   95.81%   -0.09%     
==========================================
  Files           8        8              
  Lines         731      740       +9     
==========================================
+ Hits          701      709       +8     
- Misses         30       31       +1     
Impacted Files Coverage Δ
src/algorithms/Dichotomy.jl 98.03% <ø> (-0.04%) ⬇️
src/MultiObjectiveAlgorithms.jl 90.59% <90.90%> (-0.04%) ⬇️
src/algorithms/DominguezRios.jl 100.00% <100.00%> (ø)
src/algorithms/EpsilonConstraint.jl 96.66% <100.00%> (ø)
src/algorithms/KirlikSayin.jl 98.21% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@odow odow merged commit 79d4bf5 into master Feb 25, 2023
@odow odow deleted the bl/S_param branch February 25, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants