Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish official version for Go module #2879

Closed
5 of 10 tasks
lcheylus opened this issue Jul 18, 2022 · 2 comments
Closed
5 of 10 tasks

Publish official version for Go module #2879

lcheylus opened this issue Jul 18, 2022 · 2 comments
Assignees

Comments

@lcheylus
Copy link
Contributor

  • I have read through the manual page (man fzf)
  • I have the latest version of fzf
  • I have searched through the existing issues

Info

  • OS
    • Linux
    • Mac OS X
    • Windows
    • Etc.
  • Shell
    • bash
    • zsh
    • fish

Problem / Steps to reproduce

When I try to get Go module version for your FZF project, the version is incorrect :

$ go list -m github.com/junegunn/fzf@0.30.0
github.com/junegunn/fzf v0.0.0-20220404140143-209366754892

It's a pseudo-version number (see https://go.dev/doc/modules/publishing) but it would be better if version was 0.30.0.

Thus, the versions for fzf are not published on Go Module Mirror https://proxy.golang.org/

$ go list -m --versions github.com/junegunn/fzf
github.com/junegunn/fzf

For some automatic builds for OS packaging, the version returned by go list -m <module> is used to determine the current version. And with pseudo-version number, it's not handled properly. See for example, automatic build of FZF for OpenBSD OS https://github.com/openbsd/ports/blob/master/sysutils/fzf/Makefile

Please could you publish the release versions of FZF on Go Module Mirror with the correct versioning (i.e. 0.30.0 for the current version) ?

@junegunn
Copy link
Owner

junegunn commented Jul 7, 2024

Related: golang/go#32945

So, I'm going to have to create tags with v prefix. I can do that, but I'm afraid that might break automation scripts for some packages, so I can't easily decide to do so from now on. One option would be to push both v#.#.# and #.#.#.

junegunn added a commit that referenced this issue Jul 7, 2024
New tags will have `v` prefix.

* #2879
* golang/go#32945
@junegunn junegunn self-assigned this Jul 7, 2024
junegunn added a commit that referenced this issue Jul 7, 2024
New tags will have `v` prefix.

* #2879
* golang/go#32945

Close #2879
junegunn added a commit that referenced this issue Jul 8, 2024
New tags will have `v` prefix.

* #2879
* golang/go#32945

Close #2879
@lcheylus
Copy link
Contributor Author

lcheylus commented Jul 8, 2024

@junegunn Thanks to fix this issue :)

The latest version 0.54.0 of fzf is now published on https://pkg.go.dev :)

$ go list -m github.com/junegunn/fzf@latest
github.com/junegunn/fzf v0.54.0

@lcheylus lcheylus changed the title Publish official version for Go module version Publish official version for Go module Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants