Skip to content

Fix documents link path in grow preset #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2021
Merged

Fix documents link path in grow preset #1

merged 1 commit into from
Jan 20, 2021

Conversation

sebil
Copy link
Contributor

@sebil sebil commented Jan 20, 2021

In order to be recognized as valid documents, grow needs the leading slash on the documents path.
Otherwise e.g.partial.path_format would return None

@sebil sebil requested a review from bezoerb January 20, 2021 15:34
bezoerb
bezoerb approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@bezoerb bezoerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bezoerb
Copy link
Member

bezoerb commented Jan 20, 2021

Thanks @sebil :)

@bezoerb bezoerb merged commit 84eeff2 into main Jan 20, 2021
@bezoerb bezoerb deleted the fix/grow-preset-path branch January 20, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bezoerb bezoerb bezoerb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebil @bezoerb