Is the JUnit 4 Timeout rule supported with the Vintage engine?

[Vazzilena]

Hey,

Is junit4 timeout rule supported with the vintage engine?

We are experiencing an issue similar to #1742 when we started migrating to junit5 runners and switched to junit-platform-console-standalone-1.6.0-RC1.jar.

My impression is that old junit4 tests will be working out of the box with the junit vintage engine.

What we observe:

JUnit4's FailOnTimeout rule would create a separate thread group and thread to run the test in (including any other rule's before()/after()) : https://github.com/junit-team/junit4/blob/master/src/main/java/org/junit/internal/runners/statements/FailOnTimeout.java

JUnit5 does it differently, and it would try to run rule's after() statements on its own (in its own main thread). This results in rule's before() and after() statements run in separate threads and run in parallel which must not happen and eventually causes IllegalThreadStateException in our tests.

Is there a way to workaround this without having to migrate all the tests to junit5?

[Vazzilena]

JUnit5_vintage_engine_threaddump.txt

Attaching a thread dump that shows how two different threads are accessing in parallel the @Rule @Before and @After blocks

com.pcbsys.nirvana.junit.TestServerResource.before
and
com.pcbsys.nirvana.junit.TestServerResource.after

[sbrannen]

Can you please provide us a minimal example project demonstrating the behavior you are describing?

[Vazzilena]

Can you please provide us a minimal example project demonstrating the behavior you are describing?

Well, we figured the problem is probably caused by a fix in junit4 itself:
junit-team/junit4@63fd277#diff-b88578d0a5d0fccd1c83761372cd8cc3

Since we are originally using junit 4.12 and the platform console runner bundles internally junit 4.13 we ended up with this problem as the console runner is loaded first on our classpath. We will have to adapt our code anyway...

[marcphilipp]

@Vazzilena Thanks for the feedback! I'm thus closing this issue for now since it's root cause is in JUnit 4 and not the Vintage engine. Please report an issue in the junit4 repo in case you think there's a bug.

[Vazzilena]

Guys,
Just just a question - is there a console launcher that bundles junit 4.12 instead 4.13?
We are running into far too many issues to fix them at once… :(

[marcphilipp]

@Vazzilena Can you rollback to 5.5.2?

[Vazzilena]

@Vazzilena Can you rollback to 5.5.2?

I did and it helped. Thanks.