Skip to content

Document URI TestSource support of dynamic tests in User Guide #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 20, 2019
Merged

Document URI TestSource support of dynamic tests in User Guide #1916

merged 3 commits into from
Jun 20, 2019

Conversation

ielatif
Copy link
Contributor

@ielatif ielatif commented Jun 5, 2019 •
edited
Loading

Overview

Closes #1903

I hereby agree to the terms of the JUnit Contributor License Agreement.

Definition of Done

@sormuras
Copy link
Member

sormuras commented Jun 5, 2019

Run 'gradlew spotlessApply' to fix these violations.

@ielatif
Copy link
Contributor Author

ielatif commented Jun 5, 2019

@sormuras thanks.

@ielatif ielatif force-pushed the gh-1903 branch 2 times, most recently from 9d3c918 to 4f9405e Compare June 5, 2019 20:53
@ielatif ielatif marked this pull request as ready for review June 5, 2019 21:18
@ielatif
Copy link
Contributor Author

ielatif commented Jun 6, 2019

@sormuras ready for review now ☺️

@marcphilipp marcphilipp added this to the 5.5 GA milestone Jun 7, 2019
@marcphilipp marcphilipp requested a review from sormuras June 7, 2019 10:34
sormuras
sormuras reviewed Jun 20, 2019
View reviewed changes
Copy link
Member

@sormuras sormuras left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general -- a bit too detailed for such a small feature.

Will transform the TestSourceUrisDemo class into a sample within the existing Dynamic Test Demo.

@sormuras sormuras merged commit 35a6449 into junit-team:master Jun 20, 2019
@sormuras
Copy link
Member

Thanks @ielatif!

@marcphilipp marcphilipp modified the milestones: 5.5 GA, 5.5 RC2 Jun 20, 2019
@ielatif
Copy link
Contributor Author

ielatif commented Jun 20, 2019 •
edited
Loading

a bit too detailed for such a small feature

I was afraid not detailed it enough 😃

@ielatif ielatif deleted the gh-1903 branch June 20, 2019 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sormuras sormuras sormuras left review comments

Assignees

@ielatif ielatif

@sormuras sormuras

Labels
component: Jupiter theme: documentation
Projects
None yet
Milestone
5.5 RC2
Development

Successfully merging this pull request may close these issues.

Document URI TestSource support of dynamic tests in User Guide
4 participants
@ielatif @sormuras @sbrannen @marcphilipp