Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning function result #1

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Returning function result #1

merged 1 commit into from
Oct 11, 2023

Conversation

wolph
Copy link
Contributor

@wolph wolph commented Oct 11, 2023

With this fix the decorator will return the result from the original function so it can be used as a drop-in decorator for functions that return a value.

With this fix the decorator will return the result from the original function so it can be used as a drop-in decorator for functions that return a value.
@junnaka51 junnaka51 self-requested a review October 11, 2023 16:57
Copy link
Owner

@junnaka51 junnaka51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wolph Thank you so much! :)

@junnaka51 junnaka51 merged commit 152a197 into junnaka51:main Oct 11, 2023
@wolph
Copy link
Contributor Author

wolph commented Oct 11, 2023

I've got a few other suggestions as well if you're interested.

  1. Add the median result (or even configurable 50%, 90%, etc.)
  2. Add the option to skip the first or first few iterations to warm up. In the case of numba the first iteration is slow due to compilation.

@junnaka51
Copy link
Owner

@wolph
Thank you for the suggestions! The both sound reasonable :)

@wolph
Copy link
Contributor Author

wolph commented Oct 11, 2023

I've created a new pull request that incorporate these changes as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants