-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop singleton #25
Drop singleton #25
Conversation
README.md
Outdated
]; | ||
``` | ||
|
||
Or a [YAML](https://en.wikipedia.org/wiki/YAML) configuration file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd keep it simple with 1 example to do things. That would keep point more clear.
I like the singleton-drop change. |
Yes - I agree to drop singleton, but with one example only. |
@jupeter i can restory singleton examle and mark it as bad. |
I add bad Singleton example and remove YAML config. |
@peter-gribanov Could you decouple the singleton example to standalone item? |
@TomasVotruba I create a new section. You can complete the description. |
Thank you, this is good enough |
Fix for Don't write to global functions.
Singleton is a anti-pattern.
You change a global
config()
function to a global instance ofConfiguration
class.This is very, very bad.