Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update everything. #6

Merged
merged 1 commit into from
Aug 20, 2013
Merged

Update everything. #6

merged 1 commit into from
Aug 20, 2013

Conversation

paulmillr
Copy link
Contributor

Update brunch, chaplin, add Bower integration, source maps generation, automatic test loading, better Cordova integration.

@jupl

Update brunch, chaplin, add Bower integration, source maps generation, automatic test loading, better Cordova integration.
@paulmillr
Copy link
Contributor Author

I strongly suggest to merge cordova into master branch BTW. There are not much stuff that is required for cordova.

@jupl
Copy link
Owner

jupl commented Aug 5, 2013

Yeah, I got overwhelmed with a lot. I'm back and will start to update everything.

@paulmillr
Copy link
Contributor Author

@jupl can you merge the PR please?

@jupl
Copy link
Owner

jupl commented Aug 12, 2013

I updated my base, so there are some conflicts I needed to resolve. I also set aside some time to think as I am torn on having support to programmatically determine use of pushState. If so I need to add a helper for URLs with hash/non-hash.

@paulmillr
Copy link
Contributor Author

Chaplin will programatically determine support for pushState by default on envs like cordova from 0.11. btw.

@jupl
Copy link
Owner

jupl commented Aug 13, 2013

But there is still the issue of (non-)hash URLs and relative vs. absolute assets. (Your gist fixes that, but seems a little excessive?) Wouldn't it be easier to make a note of it and have the user choose yes/no pushState?

@paulmillr
Copy link
Contributor Author

pushState does not work with cordova at all. What allowing the choice will do?

@jupl
Copy link
Owner

jupl commented Aug 14, 2013

For me, I would like to mimic the behavior in desktop when testing non-Cordova pieces as much as possible. I even had to write apps where Cordova is simply a wrapper, meaning I can do a lot of development in the browser.

@jupl
Copy link
Owner

jupl commented Aug 14, 2013

Anywho, I got merge issues resolved and added some stuff I know my partners will like. I'm going to test out the regular version to make sure it's okay before I merge it to master. Next I'll finish up the base Cordova before integrating.

@jupl jupl merged commit 3fe344d into jupl:master Aug 20, 2013
@paulmillr paulmillr deleted the topics/update branch August 20, 2013 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants