This repository was archived by the owner on Sep 1, 2022. It is now read-only.
Implement dialog #13
Merged
Implement dialog #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
force-pushed
the
feature-dialog
branch
2 times, most recently
from
4c0810e to
d1780c6
Compare
|
@ellisonbg, @jasongrout, should we make a new repo for this, such as |
|
Nevermind, we decided to create https://github.com/phosphorjs/phosphor-dialog for this. |
|
+1 on that being in phosphor Sent from my iPhone
|
wip implement dialog wip implement dialog Remove extraneous files Remove extra css Pin the beta packages for now wip implementation Remove extra css Remove extra css Finish initial dialog implementation
blink1073
force-pushed
the
feature-dialog
branch
from
f589ad3 to
e410340
Compare
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12.
Uses https://github.com/blink1073/phosphor-dialog/tree/initial for now.