-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduced User-Defined outputs_path for Pipeline Execution #402
feat: Introduced User-Defined outputs_path for Pipeline Execution #402
Conversation
…n the run() method of Pipeline
…method of Pipeline and removed the default value from ExecutionContext
Hey @MinuraPunchihewa thanks!👌 from what I understand from you screenshots, if I specify outputs_paths then the pipeline exécutions folder is not created anymore and go straight to the location specified. Is that correct ? |
Hey @jravenel, |
Ok. I think @FlorentLvr would argue it will be best to keep the name of the folder pipeline_executions every time. Otherwise things can get messy, or give us the job to create a new folder, name it, etc when we don't really need that effort. |
Oh, I don't quite understand. I worked on this to resolve this issue, |
@@ -39,7 +39,7 @@ class ExecutionContext: | |||
output_dir: str = None | |||
output_path: str = None | |||
|
|||
def __init__(self, output_dir: str = "pipeline_executions"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MinuraPunchihewa, I think that what @jravenel refers to is to keep this default value when output_dir
is not provided, that way we will keep the local pipeline_executions
directory.
And then we can chose to completely overwrite it 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dr0p42 This default value is available in the run()
method of the the Pipeline
class.
@@ -428,7 +428,7 @@ def run( | |||
self, | |||
style: Literal["diagram", "progess"] = "diagram", | |||
monitor: bool = True, | |||
outputs_path="", | |||
outputs_path="pipeline_executions", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Dr0p42,
This is what I meant. If the parameter is not passed, the results will be stored in the pipeline_executions
directory.
I don't understand what you mean @jravenel! This PR seems to resolve the issue i had 🙈 |
@MinuraPunchihewa,
|
The question I was raising is: |
@FlorentLvr Yes, you are right. |
And my point is why do I need to specify /pipeline_executions in the output dir? Can't we have pipeline_executions created automatically ? |
@jravenel, you don't. It is default parameter in the function. @MinuraPunchihewa |
@MinuraPunchihewa, sounds good to me! You can merge the PR once all checks are valid :) |
Hey @Dr0p42, @FlorentLvr, |
@MinuraPunchihewa it's coming from the linter, go to GitHub Action you'll be able to have infos. |
Hey @jravenel, |
Calling Mr @Dr0p42 for help here 🙏 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Ok @MinuraPunchihewa @jravenel this is finally fixed :) |
;) thanks @Dr0p42. We will be implementing it today or tomorrow. |
* fix: Remove templates tab * fix: Remove usage and credits * fix: Remove links at the top and update the account button * feat: Introduced User-Defined outputs_path for Pipeline Execution (#402) * used the output_path paremeter in creating the ExecutionContext within the run() method of Pipeline * fix: Local dev * updated the default value of the outputs_path parameter in the run() method of Pipeline and removed the default value from ExecutionContext * fix: Applied Black * fix: apply black * ci(tests): Trying to fix tzlocal --------- Co-authored-by: Maxime Jublou <jubloum@gmail.com> Co-authored-by: FlorentLvr <48032461+FlorentLvr@users.noreply.github.com> * bump: version 2.10.3 → 2.11.0 * fix(dependency): update naas_drivers 0.110.2 * bump: version 2.11.0 → 2.11.1 * fix: Remove codecov upload for now * bump: version 2.11.1 → 2.11.2 * fix: Rework based on workspace arrival * fix: Applied linters --------- Co-authored-by: Minura Punchihewa <49385643+MinuraPunchihewa@users.noreply.github.com> Co-authored-by: FlorentLvr <48032461+FlorentLvr@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: actions-user <41898282+github-actions[bot]@users.noreply.github.com>
This Pull Request aims to allow users to define a custom path to store the results of their Pipeline executions. This is done by using the
outputs_path
parameter in therun()
method of thePipeline
class.Given below is an example of how this works,
As shown here, the
outputs
directory is created as specified above and the results of the pipeline executions are stored in separate sub-directories within it,The contents of the
outputs
directory,If a path is not specified, the results will be stored within the
pipeline_executions
directory, by default.Note: This directory is also visible in the above screenshot, because I have the run the Pipeline twice; once without specifying the
outputs_path
and a second time by passing the argument.