Skip to content

Avoid redundant call to _get_os_path in _dir_model #1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged

Avoid redundant call to _get_os_path in _dir_model #1547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions jupyter_server/services/contents/filemanager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ def _dir_model(self, path, content=True):
model["size"] = None
if content:
model["content"] = contents = []
os_dir = self._get_os_path(path)
os_dir = os_path
for name in os.listdir(os_dir):
try:
os_path = os.path.join(os_dir, name)
Expand Down Expand Up @@ -767,7 +767,7 @@ async def _dir_model(self, path, content=True):
model["size"] = None
if content:
model["content"] = contents = []
os_dir = self._get_os_path(path)
os_dir = os_path
dir_contents = await run_sync(os.listdir, os_dir)
for name in dir_contents:
try:
Expand Down
Loading