Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop pkg_resources #59

Merged
merged 1 commit into from Sep 28, 2022
Merged

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Sep 28, 2022

This should fix #58

@welcome
Copy link

welcome bot commented Sep 28, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@jtpio jtpio added the bug Something isn't working label Sep 28, 2022
Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I just have some questions.

@davidbrochart
Copy link
Collaborator

Let's merge and investigate the cause of the test failures later, which should be unrelated.

@davidbrochart davidbrochart merged commit cf6726d into jupyter-server:main Sep 28, 2022
@welcome
Copy link

welcome bot commented Sep 28, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@davidbrochart
Copy link
Collaborator

@jtpio You would need a 0.2.1 release, right?

@jtpio
Copy link
Member Author

jtpio commented Sep 28, 2022

@jtpio You would need a 0.2.1 release, right?

Yes that would help with jupyter/notebook#6539. Otherwise we would need to add setuptools as a dependency for the build to succeed. Thanks!

@jtpio jtpio deleted the drop-pkg-resources branch September 28, 2022 21:21
@davidbrochart
Copy link
Collaborator

OK I will need to create a 0.2.x branch and backport this change. We released 0.2.0 and 0.3.0a0 right after, without thinking we would have to come back to 0.2 again.

@davidbrochart
Copy link
Collaborator

0.2.1 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'pkg_resources'
2 participants