-
Notifications
You must be signed in to change notification settings - Fork 22
Backport PR #86 on branch main (Import shared model) #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport PR #86 on branch main (Import shared model) #88
Conversation
@davidbrochart @hbcarlos should we switch the notebook metadata to be a YMap too? |
for more information, see https://pre-commit.ci
You mean to be able to observe it individually? Right now we have a |
Just to be sure, the main difference is that we now have a YMap for the cell metata, that was not in PR 86, right? |
Co-authored-by: David Brochart <david.brochart@gmail.com>
Thanks for the review
Yes
Yes to align with how we handle the metadata at the notebook and the cell level. |
Maybe yes. |
(cherry picked from commit b7bf137)
Let's do that in another PR. |
Backport PR #86
This breaks the API of 0.2.x because the cells
metadataChange
is no more providing two map values but an array of map changes.This is unfortunate but definitely easier to work with for consumer that most of the time will listen to some specific keys.