Skip to content

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Nov 7, 2022

Backport PR #86

This breaks the API of 0.2.x because the cells metadataChange is no more providing two map values but an array of map changes.

This is unfortunate but definitely easier to work with for consumer that most of the time will listen to some specific keys.

@fcollonval
Copy link
Member Author

@davidbrochart @hbcarlos should we switch the notebook metadata to be a YMap too?

@davidbrochart
Copy link
Collaborator

You mean to be able to observe it individually? Right now we have a "meta" YMap that consists of "metadata", "nbformat" and "nbformat_minor".

@davidbrochart
Copy link
Collaborator

Just to be sure, the main difference is that we now have a YMap for the cell metata, that was not in PR 86, right?

Co-authored-by: David Brochart <david.brochart@gmail.com>
@fcollonval
Copy link
Member Author

Thanks for the review

Just to be sure, the main difference is that we now have a YMap for the cell metata, that was not in PR 86, right?

Yes

You mean to be able to observe it individually?

Yes to align with how we handle the metadata at the notebook and the cell level.

@davidbrochart
Copy link
Collaborator

Yes to align with how we handle the metadata at the notebook and the cell level.

Maybe yes.

fcollonval and others added 2 commits November 7, 2022 17:27
@fcollonval fcollonval added the enhancement New feature or request label Nov 8, 2022
@fcollonval fcollonval marked this pull request as ready for review November 9, 2022 07:54
@fcollonval
Copy link
Member Author

Yes to align with how we handle the metadata at the notebook and the cell level.

Maybe yes.

Let's do that in another PR.

@fcollonval fcollonval added the api-change Pull requests introducing an API change label Nov 9, 2022
@fcollonval fcollonval merged commit 836f52c into jupyter-server:main Nov 9, 2022
@fcollonval fcollonval deleted the backport/import-javascript-schema branch November 9, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-change Pull requests introducing an API change enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants