-
Notifications
You must be signed in to change notification settings - Fork 958
Download widget manager state #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download widget manager state #239
Conversation
Like you said, this should go in a menu. The toolbar real-estate is much too precious to add something like this. You can start by defining the Action, then it's easy to add UI for it in various places, which can be done in another PR. |
That's right. I mostly that I am working on using custom widgets outside of the notebook and I needed a convenience thing to get the serialized state. I guess that in the end, we will have some sort of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like @minrk suggests, you should probably implement this as an action. Don't add it to the toolbar, and if you want, you don't even have to work out how to add it to the menu. If implemented as an action, you'll be able to access it through the command palette.
This is great, thanks! If it makes sense, we should remember to add something to the menubar |
Download widget manager state
@SylvainCorlay in #314 I add a "widgets" menu. Would you prefer I add this action to that menu, so the user can click on it there? |
Sure no problem. We need to merge the last PR for the action to work though.
|
For now, this simply adds a button to download the widget manager state, but this should probably be in a menu.
Looking at it, I realize that the widget manager has redundant information
views
property probably does not need to be there. Especially since it only contains the top-level views in cell output areas.model_name
andmodel_module
are both at the top level and in thestate
property.