Skip to content

Add complex applications authoring section #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 8, 2022
Merged

Conversation

ibdafna
Copy link
Member

@ibdafna ibdafna commented Jul 6, 2022

Signed-off-by: Itay Dafna i.b.dafna@gmail.com

Note: this is currently under a new directory "09.00", but I suspect we will rename this to "06.00" once all other PRs have been merged.

Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

github-actions bot commented Jul 6, 2022

Binder 👈 Launch a binder notebook on branch jupyter-widgets/tutorial/add_complex_app_section

@ibdafna ibdafna requested review from mwcraig, ianhi and marimeireles July 6, 2022 20:13
Copy link
Contributor

@mwcraig mwcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! A couple of very minor comments/suggestions. Thought: would it make sense to provide some links to real apps that they could look at (maybe in the end of the last notebook)?

@mwcraig
Copy link
Contributor

mwcraig commented Jul 7, 2022

Also, this doesn't produce sensible results if you select multiple columns. Perhaps fixing that could be an exercise?

ibdafna and others added 4 commits July 7, 2022 11:52
…ipynb

Co-authored-by: Matt Craig <mattwcraig@gmail.com>
…ipynb

Co-authored-by: Matt Craig <mattwcraig@gmail.com>
…ipynb

Co-authored-by: Matt Craig <mattwcraig@gmail.com>
Co-authored-by: Matt Craig <mattwcraig@gmail.com>
@ibdafna
Copy link
Member Author

ibdafna commented Jul 7, 2022

Also, this doesn't produce sensible results if you select multiple columns. Perhaps fixing that could be an exercise?

Thanks for the review! Yeah, we can give it as an exercise. It's actually the same code from the ipydatagrid notebook, so it's a good one to give an an exercise!

@mwcraig mwcraig merged commit 9a7f3f0 into main Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants