-
Notifications
You must be signed in to change notification settings - Fork 165
Add complex applications authoring section #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! A couple of very minor comments/suggestions. Thought: would it make sense to provide some links to real apps that they could look at (maybe in the end of the last notebook)?
notebooks/09.Build-complex-libs/06.00-Build-complex-libraries.ipynb
Outdated
Show resolved
Hide resolved
notebooks/09.Build-complex-libs/06.00-Build-complex-libraries.ipynb
Outdated
Show resolved
Hide resolved
notebooks/09.Build-complex-libs/06.00-Build-complex-libraries.ipynb
Outdated
Show resolved
Hide resolved
Also, this doesn't produce sensible results if you select multiple columns. Perhaps fixing that could be an exercise? |
…ipynb Co-authored-by: Matt Craig <mattwcraig@gmail.com>
…ipynb Co-authored-by: Matt Craig <mattwcraig@gmail.com>
…ipynb Co-authored-by: Matt Craig <mattwcraig@gmail.com>
Co-authored-by: Matt Craig <mattwcraig@gmail.com>
Thanks for the review! Yeah, we can give it as an exercise. It's actually the same code from the ipydatagrid notebook, so it's a good one to give an an exercise! |
Signed-off-by: Itay Dafna i.b.dafna@gmail.com
Note: this is currently under a new directory "09.00", but I suspect we will rename this to "06.00" once all other PRs have been merged.