-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Failed to load the jupiter-notebook package": Unexpected token #30
Comments
If you write It is probably related to: https://github.com/jupyter/jupyter-js-utils/blob/master/src/dialog.ts#L8 |
Opened an issue at jupyter/jupyter-js-utils#20 |
Right, all of the jupyter-js-* repos assume the ability to |
Interesting... I'm not running into this problem but @maxxk is. We're obviously not running Webpack or SystemJS in atom-notebook, we're simply importing/requiring jupyter-js-services ( atom-notebook/lib/notebook-editor.js Line 12 in f185c49
|
Jupyter-js-services relies on jupyter-js-utils, which as a |
I think this may warrant splitting utils into those requiring css and those not requiring it, so that jupyter-js-services can continue to be used in a node context. |
Agreed. Let me know if you need my assistance 👍 |
@jasongrout, shall we make another repo called something like |
@minrk, same question ^^ |
@blink1073 for things like the dialogs? I suppose so, since they are used by multiple applications. I might say |
Yep, anything that requires the DOM or css, |
We just made https://github.com/jupyter/jupyter-js-domutils. @blink1073 - you have permission to push to it. |
Should be fixed by depending on |
Great! @blink1073 atom-notebook depends on jupyter-js-services, so would you like to me to submit a PR of jupyter-js-services that depends on this new version of jupyter-js-utils? Or would you like to do it? |
Oh, sorry, that should say |
👌 |
@gnestor Solved! I can now install and load using |
👍 |
PYTHON=python2.7 apm install jupyter-notebook
(that is, downloading the package and not using the cloned repo). I still get the same error.Atom Version: 1.4.0
System: Mac OS X 10.11.2
Thrown From: jupyter-notebook package, v0.0.8
Stack Trace
Failed to load the jupyter-notebook package
Commands
Config
{ "core": {} }
Installed Packages
The text was updated successfully, but these errors were encountered: