This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Compatibility update with widgets for Safari / Firefox support #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(c) Copyright IBM Corp. 2015
Ref jupyter/declarativewidgets#21 (c) Copyright IBM Corp. 2015
* Everything must have is=“ruth-core-import” now * urth_components path must be relative (c) Copyright IBM Corp. 2015
parente
force-pushed
the
unify-widget-urls
branch
from
efaeff2
to
502384a
Compare
parente
changed the title
|
Pushed a third commit correcting our demo notebooks for new urth widget requirements:
/cc @jhpedemonte @dalogsdon @Lull3rSkat3r: the widget change will impact your notebooks in progress |
lbustelo
added a commit
that referenced
this pull request
Oct 14, 2015
|
Ran through all the modes and browsers and it the import issue is fixed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix Safari and Firefox support in declarative widgets (jupyter/declarativewidgets#21) the path passed to the widget init function needed to change (jupyter/declarativewidgets#28).
This PR contains the path change in the dashboard
main.jsand a test notebook. It should not be merged until after the PR above is merged for widgets.