Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the default to Jupyter Server configuration file #1619

Merged
merged 2 commits into from
Feb 12, 2022

Conversation

romainx
Copy link
Collaborator

@romainx romainx commented Feb 11, 2022

Hello,

This is a follow-on to the PR #1575 in the frame of the issue #1217 aiming to switch to Jupyter Lab by default.
Since Jupyter Server is now the default backend, I think it's better to maintain it's configuration file jupyter_server_config.py instead of the Jupyter Notebook one jupyter_notebook_config.py.

  • I've simply inverted in the Dockerfile the transformation between the two files.
  • I've tried to update all the references in the doc, however I may have forgotten some.
  • I've basically updated (search & replace) the files in the directory examples/openshift, however I'm not sure they are sill working 😕.

Best 🍰

@romainx
Copy link
Collaborator Author

romainx commented Feb 12, 2022

The Sphinx check links fails because there is a link to a the file jupyter_server_config.py that does not yet exist on the master branch because it's part of this PR.

(    using/common: line  171) 
broken    https://github.com/jupyter/docker-stacks/blob/master/base-notebook/jupyter_server_config.py 
- 404 Client Error: Not Found for url: https://github.com/jupyter/docker-stacks/blob/master/base-notebook/jupyter_server_config.py

docs/using/common.md Show resolved Hide resolved
base-notebook/Dockerfile Outdated Show resolved Hide resolved
@mathbunnyru
Copy link
Member

I've basically updated (search & replace) the files in the directory examples/openshift, however I'm not sure they are sill working

I feel the same way about the whole examples folder - I'm not sure they still work at all.

@mathbunnyru
Copy link
Member

Thank you!
Once we decide to drop support for the old code, it will be a super-small change 👍

@mathbunnyru mathbunnyru merged commit 1ef8838 into jupyter:master Feb 12, 2022
@romainx
Copy link
Collaborator Author

romainx commented Feb 14, 2022

@mathbunnyru thanks a lot for the review and the merge! 👍

@romainx romainx deleted the feat-1217-1 branch February 14, 2022 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants