-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal steps to add a website #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This is looking great! Standardizing the YAML front matter is fantastic. I think, to that end, I would love to see pushing further on the structured data approach:
A notional schema for what I see thus far: title: Jupyter Extension Proposal (JEP) Front Matter
description: minimum JEP information for automated reviewing and publishing
$id: https://github.com/jupyter/extension-propsals/tree/master/29-jep-process/jep-process.md
$schema: http://json-schema.org/draft-07/schema#
type: object
required:
- authors
- date-started
- issue-number
- pr-number
- title
- type
definitions:
authors:
type: array
items:
type: string
minItems: 1
title:
type: string
issue-number:
type: number
pr-number:
type: number
date-started:
type: string
format: date
type:
description: see https://www.python.org/dev/peps/#pep-types-key
type: string
enum:
- S - Standards Track
- I - Informational
- P - Process Speaking of CI: wonderful! Perhaps we can we apply some additional checks to in-coming (and current) documents as well:
|
@bollwyvl I think both of your ideas are worth pushing on in separate issues - wanna open them up and we can discuss? I am happy to keep putting cycles into improving these docs (though suspect adopting a formal spec may need a JEP of its own?) |
wohoo, it's live: https://jupyter.org/enhancement-proposals |
This is another implementation PR of #29 - it makes minimal changes needed to get a Jupyter Book building a website from the JEPs that are here. It also does some minor re-configuration of metadata, titles, etc to make it easier to organize and parse.
It also adds a github action that will automatically build the book and push to github-pages, and the docs will be publicly available at https://jupyter.org/enhancement-proposals
Note: there are probably other things to improve here, but I wanted to take the minimal number of steps and we can always iterate in the future if people like it
Here's how it looks:
https://2-41511140-gh.circle-artifacts.com/0/html/README.html