-
Notifications
You must be signed in to change notification settings - Fork 187
Trim open standards intro #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
index.html
Outdated
@@ -226,7 +226,7 @@ <h3 class="section-header">Currently in use at</h3> | |||
<div class="architecturedescription"> | |||
<img src="assets/architectureicon2.svg" class="section-icon" alt="icon to represent jupyter architecture"> | |||
<h3 class="section-header">Open Standards for Interactive Computing</h3> | |||
<h4 class="support-paragraph">The Jupyter Notebook is based on a set of open standards for interactive computing. Think HTML and CSS for interactive computing on the web. These open standards can be leveraged by third party developers to build customized applications with embedded interactive computing.</h4> | |||
<h4 class="support-paragraph">Project Jupyter is based on open standards that third-party developers can leverage to build customized applications. Think HTML and CSS for interactive computing on the web.</h4> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original reads like it was specifically talking about the application called "Jupyter Notebook" and not the notebook format or "Project Jupyter" more generally.
I like the idea of shortening this paragraph, but I think this ambiguity between Project Jupyter (a community of people and also lots of individual applications and tools) vs. one or more applications that Project Jupyter has built (Jupyter Notebook, JupyterLab, JupyterHub, IPython, etc.) needs to be resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. Makes sense. Do you think that calling out "The Jupyter Notebook" specifically suggests that it doesn't apply to JupyterLab? That's what tripped me up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're right that it creates that question. I'm open to suggestion here, I don't really have a good one myself 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe something like "Project Jupyter promotes open standards..."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@afshin, I've made an edit to address your concerns. What do you think?
The conflicts here have been resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - tighter copy that more closely matches the structure of similar elements in the page
@palewire I know it's annoying but mind fixing these conflicts and we can merge? Apologies that this PR got missed earlier |
This is done. I'll merge. |
The copy here contains some redundancies and is a little long. I've proposed a trim. It doesn't change the message, just tightens it up.