Command not found will no longer traceback #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when a command was not found, Jupyter printed a traceback on the user:
$ jupyter foobar
Traceback (most recent call last):
File "/usr/bin/jupyter", line 33, in <module>
sys.exit(load_entry_point('jupyter-core==4.6.3', 'console_scripts', 'jupyter')())
File "/usr/lib/python3.9/site-packages/jupyter_core/command.py", line 247, in main
command = _jupyter_abspath(subcommand)
File "/usr/lib/python3.9/site-packages/jupyter_core/command.py", line 133, in _jupyter_abspath
raise Exception(
Exception: Jupyter command `jupyter-foobar` not found.
Generally, I believe users should only see tracebacks when they are debugging
stuff or when there is an unexpected "crash".
In Fedora, such traceback is detected as crash by the automatic bug reporting tool.
Now, an error message is printed to stderr instead to provide a better UX.
Fixes jupyter#211
rgbkrk
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a command was not found, Jupyter printed a traceback on the user:
Generally, I believe users should only see tracebacks when they are debugging
stuff or when there is an unexpected "crash".
In Fedora, such traceback is detected as crash by the automatic bug reporting tool.
Now, an error message is printed to stderr instead to provide a better UX.
Fixes #211