Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear the test environment before each function run #333

Merged
merged 2 commits into from
Jan 8, 2023
Merged

Clear the test environment before each function run #333

merged 2 commits into from
Jan 8, 2023

Conversation

jasongrout
Copy link
Member

See #231

This attempts to make our test environment more reproducible by setting the environment variables to a known state before each function run.

@jasongrout jasongrout added the bug label Jan 7, 2023
@jasongrout jasongrout force-pushed the cleartestenv branch 3 times, most recently from d44bac3 to 57f7ce3 Compare January 7, 2023 13:21
blink1073
blink1073 approved these changes Jan 8, 2023
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit eb65690 into jupyter:main Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasongrout @blink1073