Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More helpful default comment box message #473

Merged
merged 1 commit into from
Apr 1, 2016

Conversation

jhamrick
Copy link
Member

Fixes #462 by changing the default message to:

image

@willingc @dsblank do you think this is clear enough that it will render in the feedback (given that it doesn't actually render in the formgrader interface)? Or do you think I should also add something indicating specifically that markdown added here will render properly in the feedback?

@jhamrick jhamrick added this to the 0.3.0 milestone Mar 28, 2016
@dsblank
Copy link
Member

dsblank commented Mar 28, 2016

@jhamrick Sure, that is better; thanks!

But, I'm thinking big changes :) For example:

  • I'd like to put comments on each cell. Sometimes just commenting here (in the graded part) doesn't allow me to put the comment where I want to put it. And the notebook should have comments on cells anyway!
  • I'd like to add more cells when grading
  • the feedback should be a notebook (had to jump through hoops to get feedback to students)

@jhamrick
Copy link
Member Author

@dsblank yes, I definitely would like to have some of those things, though that is a much bigger change that is going to have to wait until after 0.3.0. Do you want to open some issues for these things?

@dsblank
Copy link
Member

dsblank commented Mar 28, 2016

Perhaps a JEP would be more appropriate?

@jhamrick
Copy link
Member Author

I don't think these things need to be in a JEP because they're pretty nbgrader specific, unless you specifically mean the thing for having comments on cells in the live notebook? But for (1) comments on other cells in the formgrader and (3) exporting feedback to notebook format, those don't need to be in a JEP, I think. For (2) adding new cells during grading, I don't think I can support that in the formgrade interface itself, but I could allow an option to view notebooks in the live notebook as editable (currently it exposes them as read-only) so that you could add new cells via that interface.

@jhamrick jhamrick merged commit e77f17d into jupyter:master Apr 1, 2016
@jhamrick jhamrick deleted the document-markdown branch April 1, 2016 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants