Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download a folder as a zip file #4781

Open
hadim opened this issue Jul 25, 2019 · 7 comments
Open

Download a folder as a zip file #4781

hadim opened this issue Jul 25, 2019 · 7 comments

Comments

@hadim
Copy link

hadim commented Jul 25, 2019

Would be nice to be able to download a folder. The Jupyter server would generate an archive of the folder (zip is in the Python standard library so no extra deps to add).

Should I open a ticket on the jupyter_server repository instead of here?

Once this feature has been integrated, adding a button on JLab and the notebook should be easy.

@hadim
Copy link
Author

hadim commented Jul 25, 2019

(if core devs agree about it, I would be happy to submit a PR)

@jasongrout
Copy link
Member

I think this is the right way to go about it: implement in the server first (and for now most people are using the notebook server, so this is the right place to do it, though probably a ticket should be opened in the jupyter server repo as well to keep track of parallel development).

@hadim
Copy link
Author

hadim commented Jul 25, 2019

Ok and it looks like I am not the only one requesting this: berkeley-dsep-infra/nbzip#19

Will open a ticket on the server repo.

@hadim
Copy link
Author

hadim commented Jul 25, 2019

Here is a first attempt: https://github.com/hadim/jupyter-archive

The backend is working but not the frontend yet.

For the backend, I am trying to set up tests but I can't get the extension to be discovered during runtime: https://github.com/hadim/jupyter-archive/blob/6ddfeb56ebeb59dc99f5a21fd45ccdea8d2fefb6/jupyter_archive/tests/test_archive_hanlder.py

@hadim
Copy link
Author

hadim commented Aug 13, 2019

The plugin works now.

@hadim
Copy link
Author

hadim commented Aug 23, 2019

I am ready to integrate the plugin into JLab and the notebook server but I will need some guidance jupyterlab-contrib/jupyter-archive#2

@hadim
Copy link
Author

hadim commented Oct 6, 2019

FTR: here is the relevant PR #4945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants