Allow root user to run tests. #1468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 18, 2016 22:05
(c) Copyright IBM Corp. 2015
(c) Copyright IBM Corp. 2015
Closed
|
I'm not convinced the dockerfile on this repo should exist at all, and we should probably just point to docker-stacks from now on. |
|
It's hard to disagree. Clearly, no one is using it. I reached for it because I thought it was the way to do a little dev without polluting my system, but volume mounting the source directory from my host is hampering that effort. |
|
Thanks a lot @jtyberg ! OK, i'm going to merge that, and we can remove the Dockerfile later. |
Closed
Carreau
pushed a commit
that referenced
this pull request
Aug 1, 2016
Allow root user to run tests. (c) Copyright IBM Corp. 2015
Carreau
pushed a commit
that referenced
this pull request
Aug 1, 2016
Allow root user to run tests. (c) Copyright IBM Corp. 2015
|
Backporting this one manually, the backporting tool will mistakenly say it has not been backported. |
minrk
pushed a commit
to minrk/notebook
that referenced
this pull request
Aug 2, 2016
Allow root user to run tests. (c) Copyright IBM Corp. 2015
minrk
pushed a commit
to minrk/notebook
that referenced
this pull request
Aug 3, 2016
Allow root user to run tests. (c) Copyright IBM Corp. 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a change to disallow root user to run the notebook server, which is all good, but it broke the Docker image build. These changes enable the Docker image to build again.
FWIW, I'm not convinced that these changes should go in, or if the Dockerfile should get more love and run as a different user, like all the docker-stacks do.
Fixes #1056