Fix for default value changes in ipython/traitlets/pull/332 #1868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this looks good to me. |
minrk
changed the title
takluyver
added a commit
to takluyver/notebook
that referenced
this pull request
Nov 3, 2016
Carreau
pushed a commit
to Carreau/jupyter_notebook
that referenced
this pull request
Nov 10, 2016
…aitlets/pull/332 Closes ipython/traitlets#342 All default values are now cross validated.
Merged
|
Backported |
minrk
pushed a commit
to minrk/notebook
that referenced
this pull request
Dec 2, 2016
See jupytergh-1868 We're also discussing changes to traitlets that might avoid the need for this, in ipython/traitlets 342. But this is the simple fix. Signed-off-by: Min RK <benjaminrk@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ipython/traitlets#342
All default values are now cross validated.