Catch and log handler exceptions in events.trigger #1941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than throwing handler errors in the call to `.trigger()` Extensions can register buggy event handlers. These should not be able to cause failures in the event-triggering code paths. This should fix several avenues where extensions (or other bugs) could prevent a notebook from loading.
|
Sounds like a good idea to me. I'll leave this for a little while for other people to look at. |
takluyver
added a commit
that referenced
this pull request
Dec 4, 2016
rather than throwing handler errors in the call to `.trigger()`, which I think we don't expect to happen (at least our code suggest we don't). Extensions can register buggy event handlers. These should not be able to cause failures in the event-triggering code paths. This should fix several avenues by which extensions (or other bugs) could prevent a notebook from loading. This closes #1602 in that the bug doesn't prevent notebook loading, but it doesn't fix the original error _parente is seeing. I don't fully understand the cause there, because notebook loading doesn't start before the page has finished loading.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than throwing handler errors in the call to
.trigger(),which I think we don't expect to happen (at least our code suggest we don't).
Extensions can register buggy event handlers. These should not be able to cause failures in the event-triggering code paths.
This should fix several avenues by which extensions (or other bugs) could prevent a notebook from loading.
This closes #1602 in that the bug doesn't prevent notebook loading, but it doesn't fix the original error @parente is seeing. I don't fully understand the cause there, because notebook loading doesn't start before the page has finished loading.