Skip to content

Conversation

minrk
Copy link
Member

@minrk minrk commented Dec 16, 2016

4.x backport of #1982

closes #1970

The only real fix is an errant + on the final replacement, which would end up skipping sequential replacements.

  • leaves trailing \r on the text, if there is one
  • use groups to avoid unnecessary replace calls (no change)
  • includes test

The only real fix is an errant `+` on the final replacement,
which would end up skipping sequential replacements.

- leaves trailing `\r` on the text, if there is one
- use groups to avoid unnecessary replace calls (no change)
- includes test
@rgbkrk
Copy link
Member

rgbkrk commented Dec 16, 2016

The build is generally flaky and broken in notebook js right, not just for these carriage return PRs?

@takluyver
Copy link
Member

Yep, it's been really flakey lately.

@takluyver takluyver merged commit f50aa57 into jupyter:4.x Dec 16, 2016
@rgbkrk
Copy link
Member

rgbkrk commented Dec 16, 2016

Alright, I'll lessen my hesitation towards merging.

@minrk minrk deleted the fixCR branch December 19, 2016 12:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants