Further highlight token info in log output #1994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add critical-level log statement at the end of startup with token info
minrk
force-pushed
the
more-token-log-no-browser
branch
from
57b7845 to
faf6032
Compare
|
One alarming thing about us logging this in general - if people choose to export their logs to external storage, this is now exposed in those logs. This helps the localhost and SSH based user so I understand why this is here, just a note for the future. |
on login page
if token came from config, assume user knows what it is or it's handled some other way.
|
@rgbkrk good call. I've switched it so that it only logs the token if it's been automatically generated. Setting a token via config would result in nothing logged. |
|
@minrk great, thank you! |
|
@minrk Looks good. Is this ready to merge? |
rgbkrk
approved these changes
Dec 21, 2016
gnestor
added a commit
that referenced
this pull request
Dec 21, 2016
gnestor
added a commit
that referenced
this pull request
Dec 21, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add critical-level log statement at the end of startup with token info
closes #1980