Use events.one vs events.on inside of CodeCell.execute
#2354
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgbkrk
reviewed
Mar 30, 2017
gnestor
commented
Mar 30, 2017
| stop_on_error : stop_on_error}); | ||
| CodeCell.msg_cells[this.last_msg_id] = this; | ||
| this.render(); | ||
| this.events.trigger('execute.CodeCell', {cell: this}); |
There was a problem hiding this comment.
@rgbkrk When a CodeCell is executed, 'execute.CodeCell' is triggered, but apparently no event is triggered when execution completes.
gnestor
commented
Mar 30, 2017
| var that = this; | ||
| this.events.on('finished_iopub.Kernel', function (evt, data) { | ||
| this.events.one('finished_iopub.Kernel', function (evt, data) { | ||
| if (that.kernel.id === data.kernel.id && that.last_msg_id === data.msg_id) { |
There was a problem hiding this comment.
When 'finished_iopub.Kernel' is triggered and its data matches that of the CodeCell, then we know that execution is complete.
gnestor
commented
Mar 30, 2017
| this.events.trigger('execute.CodeCell', {cell: this}); | ||
| var that = this; | ||
| this.events.on('finished_iopub.Kernel', function (evt, data) { | ||
| this.events.one('finished_iopub.Kernel', function (evt, data) { |
There was a problem hiding this comment.
However, I just realized that if another cell's execution completes in between this cell's execution starting and completing, then this event listener will be disposed before it can handle execution completion...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches #2061
Closes #2352