fix some absolute URL paths #2430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absolute URLs should never occur in the javascript
willingc
approved these changes
Apr 19, 2017
takluyver
reviewed
Apr 19, 2017
| link.type = 'image/x-icon'; | ||
| link.rel = 'shortcut icon'; | ||
| link.href = src; | ||
| link.href = utils.url_path_join(utils.get_body_data('baseUrl'), src); |
There was a problem hiding this comment.
The paths passed into this function have a leading / - is this OK, or do they need to be changed as you've changed the other path below?
There was a problem hiding this comment.
@minrk ping! If you decide this isn't a problem, feel free to push the green button.
There was a problem hiding this comment.
url_path_join strips intermediate /, so this is fine.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URLs always need to be relative to base_url in the javascript, because they will 404 when run on a non-empty URL prefix (e.g. JupyterHub).
closes jupyterhub/jupyterhub#1086
I also removed a couple of outdated and incorrect examples while finding other instances of mistaken absolute paths.