Redirect paste menu items to call actions #2431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Can we ask you to redo it avoiding the whitespace changes, though? They can cause merge conflicts and make things like git-blame less useful. It should be possible to configure your editor not to trim trailing whitespace automatically. |
acrule
changed the title
acrule
changed the title
|
Certainly. The changes should now be free of the trailing whitespace edits. Thanks for bearing with me. |
|
Thanks, this looks good to me. :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2415 regarding paste menu items calling the notebook's paste functions directly rather than the relevant actions.
My apologies for all the extraneous changes in notebook.js and notificationarea.js. It seems my text editor automatically removed trailing whitespace on a number of lines. The substantial changes in notebook.js are at line 1570.