Skip to content

Add buffers argument to comm open/close #2731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2017
Merged

Add buffers argument to comm open/close #2731

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05c1f6f
Add buffers argument to comm open/close
vidartf Aug 7, 2017
9249ae2
Add buffers argument to CommManager.new_comm
vidartf Aug 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions notebook/static/services/kernels/comm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ define([
kernel.register_iopub_handler(msg_type, $.proxy(this[msg_type], this));
}
};
CommManager.prototype.new_comm = function (target_name, data, callbacks, metadata, comm_id) {

CommManager.prototype.new_comm = function (target_name, data, callbacks, metadata, comm_id, buffers) {
/**
* Create a new Comm, register it, and open its Kernel-side counterpart
* Mimics the auto-registration in `Comm.__init__` in the Jupyter Comm.
Expand All @@ -40,7 +40,7 @@ define([
*/
var comm = new Comm(target_name, comm_id);
this.register_comm(comm);
comm.open(data, callbacks, metadata);
comm.open(data, callbacks, metadata, buffers);
return comm;
};

Expand Down Expand Up @@ -147,13 +147,13 @@ define([
};

// methods for sending messages
Comm.prototype.open = function (data, callbacks, metadata) {
Comm.prototype.open = function (data, callbacks, metadata, buffers) {
var content = {
comm_id : this.comm_id,
target_name : this.target_name,
data : data || {},
};
return this.kernel.send_shell_message("comm_open", content, callbacks, metadata);
return this.kernel.send_shell_message("comm_open", content, callbacks, metadata, buffers);
};

Comm.prototype.send = function (data, callbacks, metadata, buffers) {
Expand All @@ -163,13 +163,13 @@ define([
};
return this.kernel.send_shell_message("comm_msg", content, callbacks, metadata, buffers);
};
Comm.prototype.close = function (data, callbacks, metadata) {

Comm.prototype.close = function (data, callbacks, metadata, buffers) {
var content = {
comm_id : this.comm_id,
data : data || {},
};
return this.kernel.send_shell_message("comm_close", content, callbacks, metadata);
return this.kernel.send_shell_message("comm_close", content, callbacks, metadata, buffers);
};

// methods for registering callbacks for incoming messages
Expand Down