Attempt to fix mysterious mathjax callback error #2792
Conversation
|
@takluyver Excellent!! Thanks for tracking this down! With your blessing, I will merge this and create a new rc release. |
|
That's fine by me - I think it's the easiest way to get people to test it. I have run with this locally and it doesn't obviously break anything for me, but I haven't tried using the equation numbering the code in question was meant to enable. |
|
The code doesn't enable equation numbering. It enables assigning labels to
equations without breaking them on further renders.
If you render the same cell twice does it produce a weird box around he raw
text of the internals instead of showing displayed math?
…On Wed, Aug 23, 2017 at 06:19 Thomas Kluyver ***@***.***> wrote:
That's fine by me - I think it's the easiest way to get people to test it.
I have run with this locally and it doesn't obviously break anything for
me, but I haven't tried using the equation numbering the code in question
was meant to enable.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2792 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACXg6FhSewDVxB1yBnjliCIN1IcWAalqks5sa_y9gaJpZM4O-a9Z>
.
|
Not for me. Rendering mathematical expressions appears to be working as it does in master, at least on my system. |
|
Including if you have a label in the eq? Sorry, I should have been specific.
…On Wed, Aug 23, 2017 at 08:15 Thomas Kluyver ***@***.***> wrote:
If you render the same cell twice does it produce a weird box around he
raw text of the internals instead of showing displayed math?
Not for me. Rendering mathematical expressions appears to be working as it
does in master, at least on my system.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2792 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACXg6LpnG1kFN7ZD2XUoffpEyAaCJEvbks5sbBftgaJpZM4O-a9Z>
.
|
|
How do you put a label in the equation? |
|
\label{your_label} should work
…On Wed, Aug 23, 2017 at 10:06 Thomas Kluyver ***@***.***> wrote:
How do you put a label in the equation?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2792 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACXg6GUM5duh4PtrnBl9wqpa-hG95n35ks5sbDHCgaJpZM4O-a9Z>
.
|
|
Seems to be fine. I've flipped it between rendered and unrendered a few times. |
|
@takluyver Thank you :D I haven't seen the mathjax error while using this fix. 🎉 |
Looking at #2733 again, I noticed that @willingc's JS console did show tracebacks, which I had somehow overlooked before. Partly that was just me not looking closely enough, but we can also make it stand out more by logging it with
console.error, which this PR does.That pointed to the code which was modified in PR #2677 just last month; this fits with people first running into the error when we made an RC.
That change asks Mathjax to call
MathJax.InputJax.TeX.resetEquationNumbers()after typesetting each thing. That function is defined in a Mathjax extensionextensions/TeX/AMSmath.js. While I still can't reproduce the error, I guess that looking up the function is in a race condition with the extension loading; if it loses the race, then there's nothing to call, so an error pops out.This PR:
Requirecall immediately before to ensure that the extension is loaded before we use it.If this passes review, I suggest that we make an RC3 soon after merging it and ask the people who can reproduce the issue to see if it's fixed.