Skip to content

Conversation

PHaeJin
Copy link
Contributor

@PHaeJin PHaeJin commented Nov 11, 2017

No description provided.

@Carreau
Copy link
Member

Carreau commented Nov 11, 2017

Hi there ! Thanks for your pull request.

It looks like you may have struggled a bit with git; did you managed to do what you were looking for, or do you need guidance to fix a couple of things ? There seem to be a couple of changes that disappeared in your final version.

Git can be quite confusing and it may take a couple of month to be fluent with it; we'll be happy to offer advice.

@takluyver
Copy link
Member

I think you're reusing the master branch for a series of pull requests, merging our master branch into it each time.

We can resolve that here, but it's neater to make a new branch for each change you want to submit. Something like this:

git clone https://github.com/jupyter/notebook.git
cd notebook
git remote add PHaeJin https://github.com/PHaeJin/notebook.git

# Make a new branch
git checkout -b typo1

# Make your changes, then commit
git commit -m "Fix a typo"

git push -u PHaeJin typo1

That way you won't have an ever-increasing number of commits in each pull request.

@PHaeJin
Copy link
Contributor Author

PHaeJin commented Nov 13, 2017

thank you for your advice!!
i will fix it right away.

@takluyver
Copy link
Member

This was merged as #3043 , so I'll close this one.

@takluyver takluyver closed this Nov 13, 2017
@takluyver takluyver added this to the Reference milestone Nov 13, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants