Update styles for inline run button #3776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
previously approved these changes
Jul 18, 2018
|
In testing this PR, I noticed a weird alignment issue:
As cells are executed, the prompt changes width. |
|
I'm seeing this in master too:
|
|
I just pushed a fix that should solve the problem as long as the execution count is under 10,000 😺
|
|
I didn't see the misalignment on this, but while I was checking, I did discover a misalignment between code and markdown cells: #3781. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3772
This does not display the inline run button on desktop (non-mobile) because it has proven to be distracting and not really useful for desktop.
It also makes the input prompt and run button inline so that they don't take up 2 separate lines.
Before:
After: