fix uneven input/output prompt alignment #3913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
force-pushed
the
fix-prompt-alignment
branch
2 times, most recently
from
f134d42 to
37b35dc
Compare
|
This was actually fixed by #3772. This PR now just makes it harder to get back into this situation by removing the separate sources for input and output prompt width, since they must always be the same. |
Carreau
approved these changes
Sep 14, 2018
|
LGTM, thanks ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something got a little wonky with prompt and output alignment (see #3781 and #3784). This is master:
and this is with this PR, where everything is back where it belongs:
closes #3902