Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use in to fix #4303 #4349

merged 1 commit into from Jan 16, 2019


Copy link

Following the discussion at #4340, in Python 2 we need rather than open if using a file descriptor rather than a file name.

This is the first commit from #4348; I got confused and asked @slel to make further changes, which weren't useful.

Following the discussion at jupyter#4340, in Python 2 we need ``
rather than `open` if using a file descriptor rather than a file name.
@takluyver takluyver added this to the 5.7.5 milestone Jan 16, 2019
@takluyver takluyver merged commit cf3622c into jupyter:5.7.x Jan 16, 2019
@takluyver takluyver deleted the io-open-fd branch January 16, 2019 13:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants