Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pytest and handle warnings #6338

Merged
merged 6 commits into from
Apr 1, 2022
Merged

Add pytest and handle warnings #6338

merged 6 commits into from
Apr 1, 2022

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Apr 1, 2022 •
edited
Loading

Adapted from similar logic in jupyterlab_server

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022

Binder 👈 Launch a Binder on branch blink1073/notebook/add-pytest

@blink1073 blink1073 marked this pull request as ready for review April 1, 2022 17:38
@blink1073 blink1073 requested a review from jtpio April 1, 2022 17:38
@jtpio
Copy link
Member

jtpio commented Apr 1, 2022

Thanks!

Looks like the test failures are related?

@blink1073
Copy link
Contributor Author

Yup, looks like I had outdated dependencies locally.

@blink1073 blink1073 merged commit 64eed5c into jupyter:main Apr 1, 2022
@blink1073 blink1073 deleted the add-pytest branch April 1, 2022 20:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jtpio jtpio Awaiting requested review from jtpio

Assignees
No one assigned
Labels
maintenance status:resolved-locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blink1073 @jtpio