Clean up pre-commit #6349
Merged
Clean up pre-commit #6349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
blink1073
commented
Apr 8, 2022
blink1073
commented
- Move some checks to CI-only
- Update docs
- Add doc8 check
|
|
jtpio
reviewed
Apr 9, 2022
app/package.json
Outdated
| "@jupyterlab/user": "~4.0.0-alpha.8", | ||
| "@jupyterlab/user-extension": "~4.0.0-alpha.8", | ||
| "@jupyterlab/vega5-extension": "~4.0.0-alpha.8", | ||
| "@jupyterlab/application": "~4.0.0-alpha.7", |
There was a problem hiding this comment.
Looks like these changes were unintentional?
There was a problem hiding this comment.
They came from the integrity check that ran on push
There was a problem hiding this comment.
Right the check is pretty simple for now and picks the versions of the locally installed packages (need to fix that so it's a bit smarter).
There was a problem hiding this comment.
Gotcha, reverted after a git clean.
jtpio
reviewed
Apr 19, 2022
| @@ -29,7 +29,5 @@ timeout = 300 | |||
| # timeout_method = "thread" | |||
| filterwarnings = [ | |||
| "error", | |||
| # Pending release of https://github.com/jupyterlab/jupyterlab_server/pull/259 | |||
| "ignore:metadata:DeprecationWarning", | |||
There was a problem hiding this comment.
Looks like we still need that jupyterlab_server release (2.12.1 or 2.13?) before being able to remove it.
Noticed in #6369.
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.